Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common setup shell script for linux distros and MacOS #715

Merged
merged 6 commits into from
Apr 1, 2019
Merged

Common setup shell script for linux distros and MacOS #715

merged 6 commits into from
Apr 1, 2019

Conversation

kmehant
Copy link
Collaborator

@kmehant kmehant commented Mar 24, 2019

Description

This pull request adds a setup shell script which does dependency installation automatically across various linux distros and MacOS.
Below are the operating systems covered:

  • CentOS (yum)
  • Fedora (dnf)
  • Ubuntu (apt/apt-get)
  • ArchLinux (pacman)
  • MacOS (brew)

Related Issue

#714

Motivation and Context

There isn't any dedicated dependency installation script for variuos linux distros and MacOS.
This solves the hassle of installing dependencies on various linux distros and MacOS which makes developer's job easy.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kmehant
Copy link
Collaborator Author

kmehant commented Mar 24, 2019

@agentmilindu @vivonk Please review.

rajikaimal
rajikaimal reviewed Mar 25, 2019
View reviewed changes
README.md Show resolved Hide resolved
vivonk
vivonk reviewed Mar 25, 2019
View reviewed changes
setup.sh Show resolved Hide resolved
vivonk
vivonk approved these changes Mar 26, 2019
View reviewed changes
Copy link
Collaborator

@vivonk vivonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Nice work @kmehant

@vibhorgupta-gh vibhorgupta-gh mentioned this pull request Mar 26, 2019
Closed
8 tasks
@kmehant kmehant requested review from rajikaimal and agentmilindu and removed request for rajikaimal March 26, 2019 19:49
@vivonk vivonk merged commit bafe0d8 into scorelab:develop Apr 1, 2019
@kmehant kmehant deleted the common-setup-script branch April 6, 2019 04:32
@kmehant kmehant added enhancement GSoC-2019 Tasks for GSoC-2019 labels Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samagragupta samagragupta samagragupta approved these changes

@vivonk vivonk vivonk approved these changes

@rajikaimal rajikaimal rajikaimal approved these changes

@malithsen malithsen Awaiting requested review from malithsen

@rehrumesh rehrumesh Awaiting requested review from rehrumesh

@agentmilindu agentmilindu Awaiting requested review from agentmilindu

Assignees
No one assigned
Labels
enhancement GSoC-2019 Tasks for GSoC-2019
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kmehant @agentmilindu @rajikaimal @vivonk @samagragupta